Skip to content

Conversation

@renkun-ken
Copy link
Member

What problem did you solve?

Closes #814

This PR makes httpgd plot viewer now respect r.session.viewers.viewColumn.plot. The value of plot view column is obtained from the settings on the creation of each httpgd plot viewer. The change of plot view column could be updated on creating new devices with new plot viewers.

(If you have)Screenshot

(If you do not have screenshot) How can I check this pull request?

Change the value of r.session.viewers.viewColumn.plot and create a new plot. Use dev.off() and create a new plot to use the latest setting.

Copy link
Member

@ManuelHentschel ManuelHentschel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@renkun-ken renkun-ken merged commit fc42b64 into master Oct 11, 2021
@renkun-ken renkun-ken deleted the httpgd-plot-view-column branch October 11, 2021 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vscode-r ignore r.session.viewers.viewColumn plot when using httpgd device for ploting

3 participants