Use cwd in knit process #807
Merged
+8
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renkun-ken
reviewed
Sep 30, 2021
src/rmarkdown/manager.ts
Outdated
| ...scriptArgs | ||
| } | ||
| }, | ||
| cwd: vscode.workspace.workspaceFolders[0].uri.fsPath |
Member
There was a problem hiding this comment.
Maybe we should use the workspace folder of the rmd file (workspace.getWorkspaceFolder(document.uri)) to knit so that multi-root workspace is supported?
ElianHugh
added a commit
to ElianHugh/vscode-R
that referenced
this pull request
May 12, 2022
* Respect cwd * Start knit process from knitWorkingDirectory * Refine getKnitDir Co-authored-by: Kun Ren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make knitting sessions use the current workspace folder as cwd, so that .Rprofile is respected. Closes #800.
How can I check this pull request?