Skip to content

Conversation

@renkun-ken
Copy link
Member

What problem did you solve?

Closes #802

The setting r.session.viewers.viewColumn.helpPanel was not respected by the help viewer. Now it is always used before opening a WebView of help viewer.

(If you do not have screenshot) How can I check this pull request?

  1. Open help for selection, and the help viewer should by default appear in view column "Two".
  2. Close the help viewer.
  3. Change setting r.session.viewers.viewColumn.helpPanel to "Active".
  4. Open help for selection again, and the help viewer should appear in view column "Active".

Copy link
Member

@ManuelHentschel ManuelHentschel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@renkun-ken renkun-ken merged commit 8808f8e into REditorSupport:master Sep 30, 2021
ElianHugh pushed a commit to ElianHugh/vscode-R that referenced this pull request May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

the operation of help pages in side bar ignore the vscode setting before I run a help command in R terminal

2 participants