Skip to content

Conversation

@ElianHugh
Copy link
Collaborator

Updates the type definitions for vscode. I'm not sure where to obtain the changelog from!


I thought this was automated, but while looking into vscode's new features I was getting type errors.

@renkun-ken
Copy link
Member

Looks like something should be fixed.

Copy link
Member

@renkun-ken renkun-ken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElianHugh ElianHugh merged commit f88df17 into REditorSupport:master Sep 13, 2021
@ElianHugh ElianHugh deleted the bump-vscode-types branch September 13, 2021 05:44
@renkun-ken
Copy link
Member

I'm about to make a new release, but I find the version in package.json is still 1.57.0 at

"vscode": "^1.57.0"

and

"@types/vscode": "^1.57.0",

Should we also update the version here?

@ElianHugh
Copy link
Collaborator Author

Sorry, I lost track of this! I think it's probably safe to update, given we tend to look into new features?

ElianHugh added a commit to ElianHugh/vscode-R that referenced this pull request May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants