Add icons to webviews #759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use the UriIcon constructor to create icon uris
- Removes the search.svg icon, as open-preview.svg was used instead
renkun-ken
reviewed
Aug 19, 2021
ElianHugh
added a commit
to ElianHugh/vscode-R
that referenced
this pull request
May 12, 2022
* Add icons to webviews * Use class for icon sourcing - Use the UriIcon constructor to create icon uris * Remove unused icon - Removes the search.svg icon, as open-preview.svg was used instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem did you solve?
Resolves #757. This adds icons to the webviews contributed by VSCode-R. At present, VSC-R webviews use the default webview panel icon. I think it would be useful if we changed these to icons that better explain what the panel is at a glance.
As
webview.iconPathcurrently requires a URI, we can't use thenew ThemeIcon()call, so icons have been obtained from the vscode icon repo. This PR adds the following icons:Screenshot