Skip to content

Conversation

@randy3k
Copy link
Member

@randy3k randy3k commented Sep 8, 2024

  • remove the variable.other.r scope to make the syntax highlighting rule more consistent with other languages such as python
  • httpgd 0.1.7 doesn't pass npm pretest
  • fix a bunch of npm audit

dependabot bot and others added 3 commits September 3, 2024 22:14
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4.1.7.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v3...v4.1.7)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
To be more consistant with other languages such as python
0.1.7 doesn't pass npm pretest
@randy3k randy3k requested a review from renkun-ken September 8, 2024 05:41
@randy3k
Copy link
Member Author

randy3k commented Sep 8, 2024

@renkun-ken
Do you mind adding me as another owner in the openvsx registry? I have decided to put more time in vscode, so it may make sense to me to be able to publish to openvsx. Thanks.

Copy link
Member

@renkun-ken renkun-ken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@renkun-ken renkun-ken merged commit c937cdd into master Sep 12, 2024
@renkun-ken
Copy link
Member

renkun-ken commented Sep 12, 2024

@renkun-ken Do you mind adding me as another owner in the openvsx registry? I have decided to put more time in vscode, so it may make sense to me to be able to publish to openvsx. Thanks.

Of course... done

@WallBPG
Copy link

WallBPG commented Apr 14, 2025

I think this breaks variable highlighting when using "<-"

@randy3k
Copy link
Member Author

randy3k commented Apr 14, 2025

Can you elaborate? The change is supposed to bring more consistency with other languages such as python.

@WallBPG
Copy link

WallBPG commented Apr 14, 2025

The assignment operator in R can be =, but is <- by standard practice. The variables are not highlighted correctly as a result of this change when using <- as an assignment operator. There could be a fix, but I don't have a lot of experience with VScode extensions. See lintr for more info on standard syntax for R: https://lintr.r-lib.org/
Screenshot 2025-04-14 134754

@randy3k
Copy link
Member Author

randy3k commented Apr 20, 2025

Hi, the coloring for var1 indeed was the correct and intended. It is consistent with how python and other languages handle variables.

However, it does seem that the var2 = 2 was incorrectly highlighted, it is supposed to be only highlighted within a function call, e.g. foo(var2 = 123).

@WallBPG
Copy link

WallBPG commented Apr 20, 2025

Python and other languages handle variables differently. The light blue represents variables in all my python scripts, which is why I thought there was an unintended issue here. Can there be an option to customize syntax highlighting as users wish?

@randy3k
Copy link
Member Author

randy3k commented Apr 21, 2025

I am pushing some more updates in #1605.

Below are my highlights for python and R.

python
image
r
image

Can you put your cursor in your python var2 equivalance and report "Inspect Editor Tokens and Scopes" like this?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants