Skip to content

Conversation

@pawelru
Copy link
Contributor

@pawelru pawelru commented May 6, 2024

a follow-up on #1520

There is one more occurrence where this function is called on numeric. On R 4.4.0 it is failing

r$> numeric_version(0)
Error in .make_numeric_version(x, strict, .standard_regexps()$valid_numeric_version) : 
  invalid non-character version specification 'x' (type: double)

Copy link
Member

@renkun-ken renkun-ken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@renkun-ken renkun-ken merged commit bc47b97 into REditorSupport:master May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants