Autocompletion of session variables in Rmd

[roaldarbol]

Describe the bug
When writing the name of a data frame followed by $ the column names should pop up; they do in a plain R script, but not in R Markdown. It might relate to #213 and be a languageserver issue, but (REditorSupport/languageserver#424 (comment)) suggests that it shoudl be working natively with vscode-R.

To Reproduce
Steps to reproduce the behavior:

1. Create dummy data frame in a fresh R/Rmd script (e.g. df <- data.frame(x = c(1, 2, 3), y = c(4, 5, 6)))
2. Start new line with df$ - in the plain R script you'll see the column suggestions, in Rmd you won't.

Do you want to fix by self? (We hope your help!)

No (sorry!)

(If yes,) what kind of help do you want? (e.g. Which file should I fix, Survey (related documents)

In case it's just because I've missed a setting or something similar, then a pointer - otherwise consider it a feature request. :-)

(If related)setting.json

{
    "editor.formatOnType": true,
    "workbench.colorTheme": "One Dark Pro",
    "r.rterm.mac": "/Users/myusername/opt/anaconda3/bin/radian",
    "r.bracketedPaste": true,
    "r.plot.useHttpgd": true,
}

Expected behavior
I would expect the same behaviour in Rmd as in plain R.

Screenshots
Data frame present in workspace:

Autocompletion in plain R:

Autocompletion doesn't see the session variables in Rmd:

But autocomplete works for non-session objects:

Environment (please complete the following information):

• OS: MacOS Big Sur
• VSCode Version: 1.60.0-insider
• R Version: 4.1.0
• vscode-R version: 2.2.0

[renkun-ken]

It is caused by LiveCompletionItemProvider only registered for r, not rmd. To make it also work with rmd, then the following needs to be done:

• Generalize the document selector by including both r and rmd
• Check if cursor is in an R code chunk if the document is rmd.

[roaldarbol]

Thanks for the quick reply, really appreciate it! Still being relatively new to VS, where do I do this?

[renkun-ken]

My comment above is just a note for development. It is not supported at the moment. I'll take a closer look this weekend.

[roaldarbol]

Ah, brilliant. Thanks for all the good work!

[roaldarbol]

Hey @renkun-ken, did you manage to take a look at this? :-)

[renkun-ken]

Sorry, didn't get a chance to look into this.

Roughly speaking, we could extend both hover and completion to rmd by detecting if the cursor is in an R code chunk if the document language is rmd.

It would be much easier if we factor the rmd code chunk detection methods so that multiple places (hover, completion, code lens, run chunk commands) could share the data.

[renkun-ken]

@roaldarbol Would you like to try the build from #787 and see if it works for you?