Old rlsp processes not being removed

[gowerc]

I'll start by saying this could likely be a user error (in which case would appreciate any advice). So through the course of development I will often close my R session and launch a new R process several times (in order to ensure a clean environment). Whilst doing this it appears that a new rlsp process is launched and the old one is not removed / cleaned up. Each process holds onto quite a large amount of memory which is slowly leading to memory exhaustion on my machine.

I am running vscode on Ubuntu Focal from windows wsl.

(unless I am misreading this and there is supposed to be that many rlsp processes?)

[renkun-ken]

Did you open documents from multi-root workspace or editing untitled files, or external files (outside workspace)? In these cases, multiple language servers are created, each has their own session pool to handle requests.

[gowerc]

In this particular instance I had 1 untitled/unsaved file. No external files and it was a single root workspace. Though I just tried forcible opening and closing the R session and it did not result in more rlsp processes being added so I'm not too sure what the root issue is atm :(

[renkun-ken]

The different ports in your screenshot suggest that they are not from the session pool but independently launched instances. Would you like to install the latest languageserver dev version, enable r.lsp.debug, start a fresh workspace with all documents closed, and try to reproduce this problem, and finally put the log here?

[gowerc]

Will do that shortly. When was the "session pool" functionality implemented. I am using currently using version 0.3.9 I think.

EDIT: Do you mean latest version of the package or the vscode extension ?

[renkun-ken]

Do you mean latest version of the package or the vscode extension

Install the latest dev of languageserver package via

remotes::install_github("REditorSupport/languageserver")

[renkun-ken]

Resolved with #941