Syntax highlighting fails when there's a vector argument

[alanocallaghan]

I came here by following the link in [...]/code/resources/app/extensions/r/syntaxes/r.tmLanguage.json so I hope I'm in the right place.

Describe the bug

A clear and concise description of what the bug is.

The following code breaks the syntax highlighting; everything after the last quote is considered part of an (unfinished) string

fun <- function(a, c = c("a", "()"), d) {
    function body, not a quoted string
}

It seems to view the close bracket within the quoted string as the end of the function args.

To Reproduce
Steps to reproduce the behavior:

1. Open an R file
2. Copy or type that code
3. Observe the results

Do you want to fix by self? (We hope your help!)

I have tried to, but I'm not familiar with textmate grammars... so... maybe? I gather I've got to mess with function-parameters so that it no longer views the close bracket as the end of the function args, probably by allowing arguments to have default values that are the evaluation of function calls

(If yes,) what kind of help do you want? (e.g. Which file should I fix, Survey (related documents)

Expected behavior
Pretty clear I think

Screenshots
Above

Environment (please complete the following information):

• OS: Linux
• VSCode Version: [e.g. 1.58.2]
• not important
• also unimportant, but I'm testing with the current language definition in this repo

[renkun-ken]

I could reproduce this. In this case, the language service does not work either when editing code below this function.

[eitsupi]

Out of curiosity, is this a problem with this extension?
The syntax highlighting seems to go wrong even in environments without vscode-R.

[renkun-ken]

It is likely that the built-in syntax does not correctly handle such case.

[eitsupi]

I looked it up and it looks like the syntax for this extension is built into vscode?
https://github.com/microsoft/vscode/blob/4f5f5de28ffbe4d9321148479d9e050cdb1551ed/extensions/r/syntaxes/r.tmLanguage.json#L3

[renkun-ken]

Thanks for the finding. Then it is up to us to fix the syntax.

[alanocallaghan]

I looked it up and it looks like the syntax for this extension is built into vscode?

Yeah that's what I meant by

I came here by following the link in [...]/code/resources/app/extensions/r/syntaxes/r.tmLanguage.json so I hope I'm in the right place.

Sorry if that wasn't clear!

[eitsupi]

There is a link to R-Box in the comment after opening the link from vscode above, but R-Box is already archived and updates are already made directly to this repository, so it would be better to modify the comment.

vscode-R/syntax/r.json

Lines 2 to 6 in 8ec924b

	"information_for_contributors": [
	"This file has been converted from https://github.com/randy3k/R-Box/blob/master/syntax/R%20Extended.sublime-syntax",
	"If you want to provide a fix or improvement, please create a pull request against the original repository.",
	"Once accepted there, we are happy to receive an update request."
	],

[ElianHugh]

(to state the obvious) it looks like brackets are still being parsed as punctuation when quoted and in the presence of function. this leads me to think it's an issue with the function-declarations definition

[eitsupi]

FYI, the syntax highlighting on GitHub seems to be normal, and the source code seems to be from this repository.
https://github.com/textmate/r.tmbundle

[ElianHugh]

FYI, the syntax highlighting on GitHub seems to be normal, and the source code seems to be from this repository.
https://github.com/textmate/r.tmbundle

Thanks for the link @eitsupi! I tested the grammar in vscode, and like you said, didn't run into any problems.

I don't know a whole lot about textmate grammar, but I wonder if there would be any issues with adopting the linked one?

[ElianHugh]

The issue is definitely with the function declarations section, replacing the function-declarations match pattern with the textmate repo's pattern fixes the issue.