Skip to content

OS process not terminated when the rterm is closed #630

@mihaiconstantin

Description

@mihaiconstantin

Describe the bug
When closing an R terminal, the associated process is not terminated.

To Reproduce
Open an R terminal in VS Code, evaluate something then close it. Repeat this, then check the process monitor.

setting.json config

{
    "r.bracketedPaste": true,
    "r.rterm.windows": "C:\\Users\\const\\AppData\\Local\\Programs\\Python\\Python39\\Scripts\\radian.exe",
    "r.rpath.windows": "C:\\Program Files\\R\\R-4.0.4\\bin\\R.exe",
    "r.lsp.debug": false,
    "r.lsp.diagnostics": false,
    "r.rterm.option": [
        "--no-save",
        "--no-restore",
        "--r-binary=C:\\Program Files\\R\\R-4.0.4\\bin\\R.exe"
    ],
    "r.sessionWatcher": true,
}

Expected behavior
When I close a terminal in VS Code the associated process to be terminated.

Screenshots

processes

Environment:

I am running the following VS Code version:

Version: 1.55.2 (user setup)
Commit: 3c4e3df9e89829dce27b7b5c24508306b151f30d
Date: 2021-04-13T09:35:57.887Z
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: 8.7.220.31-electron.0
OS: Windows_NT x64 10.0.19042

And the following R version:

platform       x86_64-w64-mingw32
arch           x86_64
os             mingw32
system         x86_64, mingw32
status
major          4
minor          0.4
year           2021
month          02
day            15
svn rev        80002
language       R
version.string R version 4.0.4 (2021-02-15)
nickname       Lost Library Book

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions