Excessive R sessions being spawned and not removed

[gowerc]

Describe the bug

It appears whilst using the extension an excessive number of R sessions are still being spawned and not released :(

To Reproduce

Use R + vscode extension + language server in a rocker/verse docker container (via attach vscode to running container) for an extended period of time.

Do you want to fix by self? (We hope your help!)

Yes, but realistically no as I don't think this is within my skillset to fix :(

(If yes,) what kind of help do you want? (e.g. Which file should I fix, Survey (related documents)

major guidance on where to even start :)

Config file

Not sure all this is needed but can provide if you think otherwise, main thing is I am using a standard R terminal not radian.

Expected behavior

R sessions to clean themselves up and not hog memory

Screenshots

Environment (please complete the following information):

• OS: Linux, Fedora 35
• VSCode Version: 1.67.2
• R Version: 4.1.2
• vscode-R version: v2.5.0

However I am running the extension in a docker container namely: rocker/r-ver:4.1.2

EDIT:

A screenshot of my R language server log:

[renkun-ken]

Would you like to provide some steps to reproduce the problem?

[gowerc]

If I'm honest this is a bit of a weird one, the problem is super reproducible in that it happens to me pretty much every day but I struggle to isolate a specific action to the problem, it just kinda occors over time if I spend an extended period of time developing in docker + vscode. i.e. after an hour of general development I check my activity monitor and see the above screenshot :(

General workflow though is:

• Spawn R docker container based on rocker/verse
• attach vscode to the running container
• Proceed to work in active container with vscode
• Notice tons of lingering processes

Will test a few more things like parallel processing and other commands to see if I can reproduce in more detail.

For reference though how many language server processes should there be if everything was running as expected ?

[eitsupi]

Note: Consider using the R definition included in the Remote - Containers extension.
This is generally the preferred method over attaching vscode to an existing container.

[gowerc]

I had forgotten about this feature, thanks for pointing it out. Will give it a try and see if I still get the same problem

[gowerc]

Nope tried using the devcontainer approach but am still seeing the same issue :(

I wondered it it might be connecting to running parallel code but that didn't see to force the issue to occur

[gowerc]

Ok, I managed to get it to be quite reliably reproducible. If I simply open a file run some code then switch to another file and run some more code it seems to quite often trigger it. It feels like its more often triggered by running devtools::load_all() but I've had cases where its done it despire never running devtools. A short clip to demo this:

output.mp4

EDIT:

The code repo I'm using if you want to experiment with my exact setup is: https://github.com/gowerc/age-of-statistics . The container is launched from the "backend" folder

[albertosantini]

Hey. Giving a quick look at the code, it seems the stack trace is the following one:

In util.ts

• executeRCommand
• spawnAsync
• spawn
• adding the process to asDisposable

It seems to me the process is disposed only when the extension is deactivated or vscode quits, if I am not wrong.

I am afraid it is missing, in this case, the trigger to dispose the process during a session.

[renkun-ken]

From your screencast, it is quite abnormal that multiple language servers are spawned to handles these files in the same workspace folder in the first place. If everything works properly, it is expected that only one language server will be spawned and should not exit until the workspace folder is closed or vscode exits.

Let me try with an environment in docker and see if I could reproduce it somehow.

[renkun-ken]

@gowerc Would you like to "toggle developer tools" and take a look at the logging in the console.

If each file triggers a new language server process, I guess it is something wrong with the file URI and the way we check if a file belongs to the current workspace folder does not work properly in your workspace for some reason.

[renkun-ken]

I tried with both a fresh container and your age-of-statistics dev container environment, but cannot reproduce the problem. Only one language server is spawned to handle the files in the same workspace folder, as expected.

[gowerc]

Apologies I've headed out for a week but will update this with the details you asked for when I get back, apologies for the delay. EDIT: I will try on a separate machine as well to see if I can reproduce the problem on different computers.

[gowerc]

Ported over my project from Fedora to Windows + wsl and am seeing the same problem, inspecting the console didn't reveal anything obvious:

Will retry after disabling all extensions to see if it from a potential conflict :S

[gowerc]

Potentially something here ?

[gowerc]

i disabled all extensions (except R and remotes) and removed all settings / keyboard shortcuts and am still seeing the same issue :(