Skip to content

Conversation

@JervenBolleman
Copy link
Contributor

This builds on the excellent work by @marqh.

I have tested it and it works for json replies only.
The existing solution binding are concatenated to the query string in an ugly way, but functional.
Would love to know how to do this nicer.

What is the procedure to get this merged?
Should the testcases not depend on dbpedia, but some test server?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 75.437% when pulling ece560a on JervenBolleman:federate2019 into e004802 on RDFLib:master.

@coveralls
Copy link

coveralls commented Dec 2, 2019

Coverage Status

Coverage increased (+0.3%) to 75.758% when pulling 56b3440 on JervenBolleman:federate2019 into e004802 on RDFLib:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 75.437% when pulling ece560a on JervenBolleman:federate2019 into e004802 on RDFLib:master.

@nicholascar nicholascar merged commit 60ad0aa into RDFLib:master Mar 12, 2020
@white-gecko white-gecko added this to the rdflib 5.0.0 milestone Apr 7, 2020
@ab-pm
Copy link

ab-pm commented Jun 23, 2021

Does this close #484 and #769?

@ghost
Copy link

ghost commented Dec 23, 2021

Does this close #484 and #769?

Yes, thanks for the references.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants