Skip to content

6.x: functionality regression from losing requests in SPARQLStore #1372

@delocalizer

Description

@delocalizer

I wish I'd noticed #1175 before it was merged to trunk and then released in 6.0.0 but anyway...

Having requests handle HTTP in SPARQLStore was powerful, and now we've lost some nice things it provided (and that we were using)

Two specific examples:

  • without an underlying requests.Session attribute it's not possible to configure connection pooling, mount Retry adapters or otherwise manipulate the HTTP coms in any advanced way.

  • clients no longer have access to the detailed content of the response to a bad query via raised requests.HttpError, (depending on your endpoint this may be e.g. SPARQL syntax error info) - now you just get back a tuple containing 4xx error code and a message.

on the whole I'd say this was a backwards move

Metadata

Metadata

Assignees

No one assigned

    Labels

    HTTPrelated to use of the HTTP protocolSPARQLregressionSomething stopped working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions