fix: page table initialization flags #1359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The kernel and user address space overlap wrt. the 1st level entry? In which case perhaps you should call the raw APIs during initialization instead of modifying the |
123abcpp
force-pushed
the
fix_pagetable_init
branch
from
ede85a8 to
bc84241
Compare
For the first level entry, the USER_ACCESSIBLE flag should be set.
123abcpp
force-pushed
the
fix_pagetable_init
branch
from
bc84241 to
b16d4b4
Compare
|
looks good to me, thanks! |
shrik3
approved these changes
Mar 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the first level entry, the USER_ACCESSIBLE flag should be set.