Finishing touches to a working MultiTensorKit code #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ub/MultiTensorKit.jl into boris-multitensorkit
This reverts commit 6236465.
This reverts commit 07dfc6c.
This reverts commit df9eb3e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR essentially adds everything that is required to be able to consistently consider a
BimoduleSector, and in particularBimoduleSector{A4}as a validSectorwithin TensorKit.Aqua tests will fail because the dependencies are not tidied up. I need to add a valid TensorKit dependency, and I think that will automatically enforce a TupleTools dependency as well. If not, that needs to be added as well. For this, my PR (still need to do) in TensorKit will first need to be merged.
Documentation is a WIP on a separate branch.