feat: Properly support S3 in IO functions #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Requires pola-rs/polars#23346 |
borchero
changed the title
delsner
reviewed
Sep 10, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #139 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 50 50
Lines 2898 2915 +17
=========================================
+ Hits 2898 2915 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
borchero
commented
Oct 17, 2025
Member
Author
|
Package code should be fine now. Tests ideally need pola-rs/polars#24922 but I think we can merge regardless. |
delsner
approved these changes
Oct 20, 2025
Member
delsner
left a comment
delsner
left a comment
There was a problem hiding this comment.
Looks good, just a few comments on the version pins.
AndreasAlbertQC
approved these changes
Oct 21, 2025
Collaborator
AndreasAlbertQC
left a comment
AndreasAlbertQC
left a comment
There was a problem hiding this comment.
LGTM, thanks for the testing, I think this is worth it <3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #87.