-
Notifications
You must be signed in to change notification settings - Fork 13
feat: Add support for deltalake #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 45 49 +4
Lines 2577 2812 +235
==========================================
+ Hits 2577 2812 +235 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
borchero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this looks great! The abstraction really shows its worth here 😄
One additional request: can we add deltalake as an optional dependency to pyproject.toml?
Good point, done. I also added |
|
Let's figure out the treatment of optional dependency testing in #135 |
borchero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just small suggestions! :)
Motivation
I would like to be able to serialize data to deltalake, including the dataframely metadata.
Changes
test_read_write_parquet.pysuch that they can easily be run for each storage backend.Testerinterface that translates the calls needed for the tests into the specifics of the backends.pytest.mark.parametrized over the differet backend testers