Skip to content

Conversation

@AndreasAlbertQC
Copy link
Collaborator

@AndreasAlbertQC AndreasAlbertQC commented Aug 6, 2025

Motivation

The current implementation of parquet-based storage is strongly coupled to the implementation of the Schema and Collection classes. This makes it hard to reuse parts of the logic that would also be useful for other future storage backends. To prepare the implementation of such future storage backends, this PR refactors the current logic to introduce a clearer interface for storage backends.

Changes

  • Introduced the notion of a StorageBackend, i.e. a piece of code encapsulating a way of storing data and metadata.
  • Refactored the parquet storage logic to use the StorageBackend interface

@codecov
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d8916e8) to head (f68fbfc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #109    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           42        45     +3     
  Lines         2450      2573   +123     
==========================================
+ Hits          2450      2573   +123     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AndreasAlbertQC AndreasAlbertQC marked this pull request as ready for review August 8, 2025 13:42
@AndreasAlbertQC
Copy link
Collaborator Author

ping @borchero

Copy link
Member

@borchero borchero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some cosmetic comments, thanks! 🚀

@AndreasAlbertQC
Copy link
Collaborator Author

Thanks @borchero! While refactoring into multiple files, I realized I had completely missed that FailureInfo also needs to be serialized. I implemented this analogously now.

Copy link
Member

@borchero borchero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go :D

@AndreasAlbertQC AndreasAlbertQC enabled auto-merge (squash) August 29, 2025 07:13
@AndreasAlbertQC AndreasAlbertQC merged commit e22274b into main Aug 29, 2025
20 checks passed
@AndreasAlbertQC AndreasAlbertQC deleted the 2025-08-06_refactor-io branch August 29, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants