Skip to content

[AR1] Update unfinished suggestions #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 10, 2024
Merged

[AR1] Update unfinished suggestions #513

merged 3 commits into from
Jul 10, 2024

Conversation

SylviaZhaooo
Copy link
Collaborator

Resolve @Jiarui-ZH's suggestions in #451.

@netlify Netlify
Copy link

netlify bot commented Jul 8, 2024 •
edited
Loading

✅ Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit 02b7bd8
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/668c6711e27713000871a229
😎 Deploy Preview https://deploy-preview-513--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024 •
edited
Loading

🚀 Deployed on https://668c68e0b571f2d4b026f1ee--taupe-gaufre-c4e660.netlify.app

@github-actions github-actions bot temporarily deployed to pull request July 8, 2024 06:33 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 8, 2024 06:35 Inactive
mmcky
mmcky reviewed Jul 8, 2024
View reviewed changes
Copy link
Contributor

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @SylviaZhaooo -- just a minor comment.

@mmcky
Copy link
Contributor

mmcky commented Jul 8, 2024

  • the unctad site is currently in maintenance mode so the linkchecker is failing. That's just unlucky :-)

@SylviaZhaooo
Copy link
Collaborator Author

  • the unctad site is currently in maintenance mode so the linkchecker is failing. That's just unlucky :-)

Yeah...just found it as well. Thanks for the comments.

@github-actions github-actions bot temporarily deployed to pull request July 8, 2024 06:51 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 8, 2024 06:52 Inactive
@mmcky
Copy link
Contributor

mmcky commented Jul 8, 2024

thanks @jstac. Once this is green I can merge.

@mmcky mmcky added the ready label Jul 8, 2024
@github-actions github-actions bot temporarily deployed to pull request July 8, 2024 22:31 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 8, 2024 22:32 Inactive
@mmcky mmcky merged commit fac9a2f into main Jul 10, 2024
7 checks passed
@mmcky mmcky deleted the update_AR1_second_round branch July 10, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmcky mmcky mmcky left review comments

Assignees
No one assigned
Labels
ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SylviaZhaooo @mmcky @jstac