Skip to content

[commod_price] Editorial Suggestions #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
8 tasks done
HumphreyYang opened this issue May 6, 2024 · 4 comments
Closed
8 tasks done

[commod_price] Editorial Suggestions #436

HumphreyYang opened this issue May 6, 2024 · 4 comments
Assignees

Comments

@HumphreyYang
Copy link
Collaborator

HumphreyYang commented May 6, 2024

Comments by @SylviaZhaooo.

Content

  • Missing period in "The lecture will discuss one way to solve a “functional equation” for an unknown function".
  • “functional equation” (the equation where the unknown object is a function).
  • Add an internal link to IID.
  • State that density function $\phi$ is defined on positive values.
  • "supply is the sum of carryover by speculators and the current harvest" -> "supply is the sum of carryover by speculators and the current harvest, and".
  • supply $=$ -> supply is given by.
  • Link Monte Carlo to the asset pricing lecture.
  • Add a y-axis for the plot of $p^*$.
@Jiarui-ZH
Copy link
Contributor

Jiarui-ZH commented May 12, 2024

comments by @pgrosser1

Content

  • -Add axis label to the graph in section 25.2, e.g cotton price in USD
  • Might consider treating $\alpha$ as a more general factor rather than just simply the depreciation rate. Can potentially delete the phrase regarding depreciation
  • Explain why we are enforcing the no arbitrage condition (25.5.1)
  • Add a few sentence explaining the logic behind equation 25.2 (25.5.1)
  • Explain that market clearing happens when supply equals demand (25.5.1)
  • For section 25.2, introduce the idea that the method is an ansatz. Also consider adding a section explaining the what an ansatz is and why rigorous can still be achieved
  • Toward the end of section 25.5.2 mention the last part of the section is verifying the ansatz

@jstac
Copy link
Contributor

jstac commented Jul 1, 2024

partially resolved by #443

@mmcky
Copy link
Contributor

mmcky commented Jul 17, 2024

@SylviaZhaooo I see that all checkboxes appear to be ticked in this issue and there were commits in #443 within the last two weeks (after @jstac comment above). Does that mean this issue can now be closed?

@mmcky
Copy link
Contributor

mmcky commented Jul 17, 2024

Thanks for your comments @pgrosser1, @SylviaZhaooo, @Jiarui-ZH, @mbek0605, and @HumphreyYang

Thanks @SylviaZhaooo for working on the associated PRs.

@mmcky mmcky closed this as completed Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants