-
Notifications
You must be signed in to change notification settings - Fork 9
Report manually marked single-threaded tests #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lysnikolaou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Additionally, I think that the Some tests *not* run in parallel line appearing even if all tests were run in parallel is also a bug that should be fixed and which is why I opened #46 initially. For example, just running test_resolver.py gives me the following.
================================================================== test session starts ===================================================================
platform darwin -- Python 3.13.2+, pytest-8.3.5, pluggy-1.5.0
rootdir: /Users/lysnikolaou/repos/quansight/pyyaml
configfile: pyproject.toml
plugins: run-parallel-0.4.0
collected 3 items
Collected 3 items to run in parallel
tests/free_threading/test_resolver.py ··· [100%]
************************************************************ Some tests *not* run in parallel ************************************************************
0 tests were not run in parallel because of use of thread-unsafe functionality, to list the tests that were skipped, re-run while setting PYTEST_RUN_PARALLEL_VERBOSE=1 in your shell environment
=================================================================== 3 passed in 0.77s ====================================================================
|
Would we agree to rephrase it as |
|
I'd be okay always showing. If all tests were run in parallel, then we could have something like this: |
lysnikolaou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a test for the new message if all tests were run in parallel?
|
@lysnikolaou @ngoldbaum do you have any additional comments? Or should we merge this one? |
lysnikolaou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Let me produce a new release! |
Fixes #46
This PR enables reporting tests that were marked as single-threaded using
@pytest.mark.parallel_threads(1), as they were not being reported before