QUA-1024: Update "Any Not Null" userguide. #932
Conversation
RafaelOsiro
left a comment
RafaelOsiro
left a comment
There was a problem hiding this comment.
About spelling mistakes, text errors, and formatting, I found these problems.
Now, about the content to review, @shindiogawa will be able to say more.
docs/checks/any-not-null-check.md
Outdated
|
|
||
| > There is no value set for any of `O_COMMENT` and `O_ORDERSTATUS` | ||
|  |
There was a problem hiding this comment.
Incorrect Image Alt Text.
The alt text says deactivate-user which is clearly copy-pasted from another document. It should describe the actual image, like anomaly-detail or any-not-null-anomaly-detail .
docs/checks/any-not-null-check.md
Outdated
|
|
||
| **Anomaly Explanation** | ||
|
|
||
| In the sample data above, the entry with `O_ORDERKEY` **1** does not satisfy the rule because both `O_COMMENT` and `O_ORDERSTATUS` does not hold a value. |
There was a problem hiding this comment.
Grammar Error.
...both O_COMMENTandO_ORDERSTATUS` does not hold a value.
Should be do not hold (plural subject requires plural verb):`
...both O_COMMENTandO_ORDERSTATUS do not hold a value.
docs/checks/any-not-null-check.md
Outdated
|
|
||
| ### Key Takeaway | ||
|
|
||
| Any Not Null acts as a safety net that prevents context-less records from silently entering the system, replacing slow and unreliable manual validation with automated enforcement. |
There was a problem hiding this comment.
Hyphenation Issue.
...prevents context-less records...
"Context-less" is awkward. Consider using "contextless" or rephrasing to "records without context".
docs/checks/any-not-null-check.md
Outdated
|
|
||
| Any Not Null acts as a safety net that prevents context-less records from silently entering the system, replacing slow and unreliable manual validation with automated enforcement. | ||
|
|
||
| ### Field Scope |
There was a problem hiding this comment.
Inconsistent Heading Hierarchy.
The section ### Field Scope appears after the "Key Takeaway" section within the example narrative. This breaks the logical flow. The Field Scope, General Properties, Anomaly Types, and Example sections should be at ## level (h2) to match the rest of the document structure, or there should be a clear visual/logical separation.
docs/checks/any-not-null-check.md
Outdated
|
|
||
| Use the **Any Not Null** check when you want to ensure that records are not completely blank across a group of related fields. | ||
|
|
||
| <!--ARCADE EMBED START--><div style="position: relative; padding-bottom: calc(78.2692% + 41px); height: 0px; width: 100%;"><iframe src="https://demo.arcade.software/YRIqJifrb6cYQeXp6mUK?embed&embed_mobile=tab&embed_desktop=inline&show_copy_link=true" title="Untitled (Wed Dec 24 2025)" frameborder="0" loading="lazy" webkitallowfullscreen mozallowfullscreen allowfullscreen allow="clipboard-write" style="position: absolute; top: 0; left: 0; width: 100%; height: 100%; color-scheme: light;" ></iframe></div><!--ARCADE EMBED END--> |
There was a problem hiding this comment.
Arcade Embed Titles (Lines 21 and 138): Both iframes have titles like Untitled (Wed Dec 24 2025). Consider adding descriptive titles for better accessibility.
docs/checks/any-not-null-check.md
Outdated
|
|
||
| ### The Solution: Any Not Null | ||
|
|
||
| <!--ARCADE EMBED START--><div style="position: relative; padding-bottom: calc(49.1909% + 41px); height: 0px; width: 100%;"><iframe src="https://demo.arcade.software/ikJs6JRwTz8xr8KsDfJ1?embed&embed_mobile=tab&embed_desktop=inline&show_copy_link=true" title="Untitled (Wed Dec 24 2025)" frameborder="0" loading="lazy" webkitallowfullscreen mozallowfullscreen allowfullscreen allow="clipboard-write" style="position: absolute; top: 0; left: 0; width: 100%; height: 100%; color-scheme: light;" ></iframe></div><!--ARCADE EMBED END--> |
There was a problem hiding this comment.
Arcade Embed Titles (Lines 21 and 138): Both iframes have titles like Untitled (Wed Dec 24 2025). Consider adding descriptive titles for better accessibility.
Overview
This PR includes updated screenshots and content as per the latest release.
Key Changes