QUA-1024: Update "After Date Time" check. #931
Conversation
RafaelOsiro
requested review from
RafaelOsiro
and removed request for
RafaelOsiro
RafaelOsiro
left a comment
RafaelOsiro
left a comment
There was a problem hiding this comment.
About spelling mistakes, text errors, and formatting, I found these problems.
Now, about the content to review, @shindiogawa will be able to say more.
docs/checks/after-date-check.md
Outdated
|
|
||
| ### Anomaly Output (Source Records View) | ||
|
|
||
| | LAST_LOGIN_TS | CUSTOMER-EMAIL | CUSTOMER_ID | |
There was a problem hiding this comment.
Inconsistent Column Header Naming
The table uses CUSTOMER-EMAIL (with hyphen) but the earlier table on line 142 uses CUSTOMER_EMAIL (with underscore). This should be consistent.
docs/checks/after-date-check.md
Outdated
| | <span class="text-negative">2022-03-01T10:00:00.000Z</span> | [email protected] | C028 | | ||
| | <span class="text-negative">2022-03-01T10:00:00.000Z</span> | [email protected] | C014 | | ||
|
|
||
|  |
There was a problem hiding this comment.
Incorrect Image Alt Text.
The image alt text says deactivate-user which doesn't match the context. It should describe the anomaly result.
Should be:
docs/checks/after-date-check.md
Outdated
|
|
||
| !!! example "Shape Anomaly" | ||
| In `O_ORDERDATE`, 66.667% of 3 filtered records (2) are not later than **1991-12-31 10:30:00** | ||
| In `O_ORDERDATE`, 66.667% of 3 filtered records (2) are not later than **1991-12-31 10:30:00** |
There was a problem hiding this comment.
Missing Newline at End of File.
The file doesn't end with a newline character. This is a minor issue but considered best practice.
docs/checks/after-date-check.md
Outdated
| **BrightCart**, an e-commerce company, migrated its **user authentication system** to a new identity provider on | ||
| **December 1, 2025 at 06:15 UTC**. |
There was a problem hiding this comment.
Line break in middle of sentence.
Remove the line break: ...migrated its **user authentication system** to a new identity provider on **December 1, 2025 at 06:15 UTC**.
docs/checks/after-date-check.md
Outdated
|
|
||
| Use the After Date Time Check to validate timestamp fields against a fixed cutoff and detect records that violate expected time boundaries. | ||
|
|
||
| <!--ARCADE EMBED START--><div style="position: relative; padding-bottom: calc(48.0208% + 41px); height: 0px; width: 100%;"><iframe src="https://demo.arcade.software/5xoq4jojtCHHXZ83n6tS?embed&embed_mobile=tab&embed_desktop=inline&show_copy_link=true" title="Untitled (Fri Dec 19 2025)" frameborder="0" loading="lazy" webkitallowfullscreen mozallowfullscreen allowfullscreen allow="clipboard-write" style="position: absolute; top: 0; left: 0; width: 100%; height: 100%; color-scheme: light;" ></iframe></div><!--ARCADE EMBED END--> |
There was a problem hiding this comment.
Arcade embed titles (Lines 19, 128) - Both embedded Arcade demos have generic titles Untitled (Fri Dec 19 2025).
Consider updating the Arcade demos with proper titles for better accessibility.
docs/checks/after-date-check.md
Outdated
|
|
||
| The data team configured an **After Date Time** check to enforce a hard time boundary. | ||
|
|
||
| <!--ARCADE EMBED START--><div style="position: relative; padding-bottom: calc(48.0208% + 41px); height: 0px; width: 100%;"><iframe src="https://demo.arcade.software/wPHCSd6kjDoxuzBWplsv?embed&embed_mobile=tab&embed_desktop=inline&show_copy_link=true" title="Untitled (Fri Dec 19 2025)" frameborder="0" loading="lazy" webkitallowfullscreen mozallowfullscreen allowfullscreen allow="clipboard-write" style="position: absolute; top: 0; left: 0; width: 100%; height: 100%; color-scheme: light;" ></iframe></div><!--ARCADE EMBED END--> |
There was a problem hiding this comment.
Arcade embed titles (Lines 19, 128) - Both embedded Arcade demos have generic titles Untitled (Fri Dec 19 2025).
Consider updating the Arcade demos with proper titles for better accessibility.
docs/checks/after-date-check.md
Outdated
|
|
||
| You specify the **exact date and time** that acts as the lower boundary. | ||
|
|
||
| **Example:** 1991-12-31 10:30:00 |
There was a problem hiding this comment.
Example date (Line 47) - The example uses 1991-12-31 10:30:00 which matches the technical example at the bottom but feels dated for a "freshness" example. The real-life example uses 2025 dates which is more appropriate.
Overview
This PR includes updated screenshots and content as per the suggestions.
Key Changes