Switch to pytest as a test runner #393
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change switches from 'python setup.py test' to 'pytest' as a test runner under the tox environment, and encourages use of tox.
This eliminates a class of test failures under Python 3 caused by usage of the unsupported path of combining tox and 'python setup.py tests':
https://tox.readthedocs.io/en/latest/example/basic.html#integration-with-setup-py-test-command
Specifically in our case, the PYTHONPATH included . and src/, which resulted in e.g. reprlib being discovered under src/ instead of in the core stdlib.