Skip to content

Coin selection fix #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 22, 2025
Merged

Coin selection fix #445

merged 4 commits into from
May 22, 2025

Conversation

tacmota
Copy link
Contributor

@tacmota tacmota commented May 19, 2025

Fix coin selection bug for the test in this branch https://github.com/Python-Cardano/pycardano/tree/coin_selection_fix

The selector didn't initialize with the remaining amount before the selector function started.

Copy link

codecov bot commented May 19, 2025

Codecov Report

Attention: Patch coverage is 89.47368% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.75%. Comparing base (d250316) to head (793e861).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
pycardano/transaction.py 89.65% 0 Missing and 3 partials ⚠️
pycardano/txbuilder.py 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #445      +/-   ##
==========================================
- Coverage   88.80%   88.75%   -0.05%     
==========================================
  Files          33       33              
  Lines        4759     4792      +33     
  Branches      723      730       +7     
==========================================
+ Hits         4226     4253      +27     
- Misses        375      378       +3     
- Partials      158      161       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tacmota tacmota force-pushed the coin_selection_fix branch from ec48a89 to 793e861 Compare May 21, 2025 01:54
Copy link
Collaborator

@cffls cffls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@cffls cffls merged commit 446a0e8 into Python-Cardano:main May 22, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants