Add version information to setup.cfg #93
Conversation
setuptools_rust/__init__.py
Outdated
| from .tomlgen import tomlgen_rust, find_rust_extensions | ||
| from .utils import Binding, Strip | ||
|
|
||
| __version__ = "0.11.6.dev1" |
There was a problem hiding this comment.
To make it easier to do releases, can we use setuptools_scm version hard-coding?
e.g. in pyproject.toml:
[tool.setuptools_scm]
write_to = "pkg/version.py"
and then refer to the generated file here?
There was a problem hiding this comment.
Nice trick! I was not aware of this feature. Please check out the update to my PR.
There was a problem hiding this comment.
Thanks! I will test this quickly 👍
setuptools_rust/__init__.py
Outdated
| from .test import test_rust | ||
| from .tomlgen import tomlgen_rust, find_rust_extensions | ||
| from .utils import Binding, Strip | ||
| from .version import __version__ |
There was a problem hiding this comment.
From testing I think this needs to be:
| from .version import __version__ | |
| from .version import version as __version__ |
... does that match your experience too?
There was a problem hiding this comment.
Oops, I initially used a template with __version__. I removed the template and forgot to re-generate version.py before I pushed the change.
There was a problem hiding this comment.
👍 yeah I considered adding a template but thought the default was nicer too.
- add `setuptools_rust.__version__` - populate setup.cfg's version field from `setuptools_rust.__version__` - require setuptools >= 46.1 Resolves: PyO3#91 Signed-off-by: Christian Heimes <[email protected]>
Signed-off-by: Christian Heimes <[email protected]>
davidhewitt
force-pushed
the
gh-91-version
branch
from
bbf34da to
120e04d
Compare
|
Many thanks! CI seemed to have an issue so I force-pushed to fix; hope that's okay. |
setuptools_rust.__version__setuptools_rust.__version__Version
0.11.6.dev1means that the current main branch is indevelopment phase of an upcoming 0.11.6 release.
Resolves: #91
Signed-off-by: Christian Heimes [email protected]