Use target CARGO_BUILD_TARGET if specified #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust will pick up the environment variable anyway, but if we don't pick up on it, too, then we won't find the build artifacts.
|
👍 thanks! I've pushed a changelog entry & will merge now. You should be able to test it by installing |
Anthchirp
added a commit
to Anthchirp/setuptools-rust-feedstock
that referenced
this pull request
Nov 16, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into a build issue on conda-forge recently, where setuptools-rust does not pick up that a CARGO_BUILD_TARGET environment variable is set. The effect of this is that the rust compilation step succeeds, but the build artifacts land in a
.../target/x86_64-unknown-linux-gnu/release/...path.setuptools-ruststill looks for them in the.../target/release/...parth though, which the fails the build.This change might fix the issue. I haven't tested it though, and I'm not a rust developer.