Use Github Actions instead of Travis #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
github-actions
branch
9 times, most recently
from
0ca7cce to
21230ad
Compare
davidhewitt
force-pushed
the
github-actions
branch
3 times, most recently
from
c4df7c0 to
0700061
Compare
davidhewitt
changed the title
|
Seems to be failing as expected, if you point the |
|
Agreed; it's pretty late here so I'm going to finish this tomorrow. Ideally in the morning but could be later in the day... |
|
As PyO3/pyo3#1179 is now merged, I'm testing this PR against the pyo3 master. Hopefully green! |
davidhewitt
force-pushed
the
github-actions
branch
from
01128ce to
c4a1244
Compare
|
I think I missed one of the toml files, so have pointed that one also at master and re-pushed. |
|
CI passed 🎉 . So this is blocked until PyO3 0.12.1 releases. |
|
😅 good to know that PR works in any event. |
davidhewitt
force-pushed
the
github-actions
branch
from
c4a1244 to
007a3ed
Compare
|
PyO3 0.12 released and working nicely here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #77 which adds testing (by migrating to github actions).
This isn't ready to merge; on the way I found that I had to build a custom pyo3 branch to fix PyPy support.
I also had to fixup a few pieces of the setuptools-rust examples to behave better cross-platform!