Skip to content

Add optional option to RustExtension #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 31, 2017
Merged

Add optional option to RustExtension #16

merged 2 commits into from
Jul 31, 2017

Conversation

messense
Copy link
Member

@messense messense commented Jul 31, 2017 •
edited
Loading

Fixes #15

@messense messense requested a review from fafhrd91 July 31, 2017 01:55
fafhrd91
fafhrd91 approved these changes Jul 31, 2017
View reviewed changes
Copy link
Collaborator

@fafhrd91 fafhrd91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add entry to changes.

do you want to make new release?

@messense
Copy link
Member Author

Sure. You want the new version be 0.7.0 or 0.6.2?

@fafhrd91
Copy link
Collaborator

0.6.2

@messense messense merged commit 502141b into PyO3:master Jul 31, 2017
@messense messense deleted the feature/optional branch July 31, 2017 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fafhrd91 fafhrd91 fafhrd91 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@messense @fafhrd91