refactoring: tidy up library and reuse more logic #116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to re-use more of the library logic into repeatable patterns. I also bumped the minimum Python version to 3.6, made liberal use of f-strings, and changed many error messages to start with lowercase.
@tiran would you be willing to pass a quick review over this? In particular the new
RustCommand
base class should ensure that optional extensions failing will always print a nice message (thanks toexcept Exception
on line 45 ofcommand.py
).Fixes #105