Bump half dependency to the current stable version #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I think the MSRV build failure is our old friend rust-lang/cargo#10954 again, c.f. tkaitchuck/aHash#127 |
davidhewitt
approved these changes
Sep 19, 2022
Member
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
Looks good though I guess we'll need to wait for 0.8.1 ahash (hopefully).
adamreichold
force-pushed
the
bump-deps
branch
from
f4c34d9 to
21d074c
Compare
adamreichold
changed the title
adamreichold
force-pushed
the
bump-deps
branch
from
21d074c to
114ab12
Compare
Bumping ahash is blocked by our MSRV policy.
adamreichold
force-pushed
the
bump-deps
branch
from
114ab12 to
f945ad9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
halfis part of our API and hence this is a breaking change. This also increases MSRV to 1.58 ifhalfis enabled. (It was already 1.51 ifhalfis enabled before, i.e. not compatible with our MSRV of 1.48.)