fix crash when dropping PyBuffer after interpreter finalized
#5242
+174
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Anyone got a few mins to review this one so we can get it into 0.26 please? 🙏 |
Icxolu
approved these changes
Aug 6, 2025
Rafa-Gu98
pushed a commit
to Rafa-Gu98/pyo3
that referenced
this pull request
Aug 9, 2025
…5242) * fix crash when dropping `PyBuffer` after interpreter finalized * newsfragment * fixup CI * fixup test cfgs * add more test coverage * fix cfg combinations
This was referenced Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4632
This adds a test that dropping
PyBuffer<T>after finalizing the interpreter won't cause a bad crash. We don't really support the interpreter lifecycle much (other than saying it'sunsafeto interact with due to risk of objects outliving the interpreter) but I think it's reasonable to attempt to avoid a segfault, at least.