Rename PYTHON_SYS_EXECUTABLE to PYO3_PYTHON #1039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
pyo3-interpreter
branch
from
7af5b02 to
56b8c2c
Compare
|
cc @konstin, who suggested originally. I'm also toying with the name |
kngwyu
reviewed
Jul 15, 2020
davidhewitt
force-pushed
the
pyo3-interpreter
branch
from
56b8c2c to
4ee026a
Compare
davidhewitt
changed the title
|
Pushed the correction, and also renamed the variable to If nobody has any objections to the new name I'll probably merge this on Sunday and write patches for |
konstin
approved these changes
Jul 18, 2020
|
👍 I plan to add patches to |
davidhewitt
force-pushed
the
pyo3-interpreter
branch
from
4ee026a to
dc5c2a9
Compare
|
I've now pushed patches both tools, so I've rebased this PR and will merge shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #539 .
Once merged, I'll update
setuptools-rustandmaturinto output both environment variables for now, as a compatible way to manage the migration.