-
Notifications
You must be signed in to change notification settings - Fork 81
Add pyproject.toml support for config (Issue #10) #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👍 This would be most welcome. |
Indeed. Most formatter and linters now support the [tool.X] section of |
I would be super cool to have |
This project is abandonware, right? |
@mdczaplicki I hope not, maybe @myint can give some info? |
@dyve Would you be interested in becoming a maintainer? |
@myint I'd be open to lending a hand to help get things moving. |
@weibullguy Welcome aboard! Thanks for sticking to this PR for a year. 🙈 |
@weibullguy |
@fmigneault I opened issue #92 to track this. As far as I know, the |
To everyone who's been waiting for some sort of config file support, I don't have the access rights to push tags or upload new releases to pypi. For now for
For adding |
@weibullguy Thanks! I hope this gets to PyPI and that the projects remains alive!
@myint I don't have the time to take on another maintainer role, but I'd say @weibullguy is stepping up. Perhaps he can also get PyPI rights? |
Done! |
I submit for your consideration a potential solution to issue #10 .
This adds two functions:
The dict is used to set default values in the add_argument() methods, thus ensuring command line options take precedence. Adding additional config files (e.g., setup.cfg, tox.ini) should be reasonably trivial with these functions.
Four tests have been added to the test suite to test these two functions and a section added to the README to explain the use of pyproject.toml. All tests pass as well as all static checks. I've been successfully using my fork for my use cases; command line, key-mapped in IDE, pre-commit and GH actions.
Closes #10