Skip to content

Conversation

@chazuttu
Copy link
Collaborator

Summary

This PR adds unit tests for the script wsremcarne.py and also increases its coverage.

  • added unit tests for wsremcarne.py
  • updated cassettes
  • added wsremcarne.ini file
  • increased coverage to 85 %

Checklist

  • Classes, Variables, function and methods logic ok
  • Comments written explaining what the code does
  • All python code is PEP8 compliant (run black .)
  • No lint issues (run flake8)
  • Test coverage with pytest implemented
  • Reviewers assigned (at least 1 mentor)

Manual test evidence

Python 3

pytest --cov-config=.coveragerc --cov=pyafipws tests/test_wsremcarne.py

=========================== test session starts ==========================
platform win32 -- Python 3.9.6, pytest-6.2.3, py-1.10.0, pluggy-0.13.1
rootdir: C:\Users\Desktop\Week_7_GSOC\pyafipws, configfile: pytest.ini
plugins: cov-2.12.1, freezegun-0.4.2, html-3.1.1, metadata-1.11.0, vcr-1.0.2
collected 40 items

tests\test_wsremcarne.py ........................................                                                                                                                                 [100%]

-- Docs: https://docs.pytest.org/en/stable/warnings.html

----------- coverage: platform win32, python 3.9.6-final-0 -----------
Name                                                                                       Stmts   Miss  Cover
--------------------------------------------------------------------------------------------------------------
test3\Lib\site-packages\PyAfipWs-3.9.b_2520_-py3.9.egg\pyafipws\__init__.py                    4      0   100%
test3\Lib\site-packages\PyAfipWs-3.9.b_2520_-py3.9.egg\pyafipws\wsremcarne.py                432     66    85%
--------------------------------------------------------------------------------------------------------------

======================== 40 passed, 15 warnings in 5.42s =================

Python 2

pytest --cov-config=.coveragerc --cov=pyafipws tests/test_wsremcarne.py

============================= test session starts =============================
platform win32 -- Python 2.7.18, pytest-4.6.11, py-1.10.0, pluggy-0.13.1
rootdir: C:\Users\Desktop\Week_7_GSOC\pyafipws, inifile: pytest.ini
plugins: cov-2.12.1, freezegun-0.4.2, html-1.22.1, metadata-1.11.0, vcr-1.0.2
collected 40 items

tests\test_wsremcarne.py ........................................        [100%]

---------- coverage: platform win32, python 2.7.18-final-0 -----------
Name                                                                                    Stmts   Miss  Cover
-----------------------------------------------------------------------------------------------------------
test2\Lib\site-packages\PyAfipWs-2.7.2520-py2.7.egg\pyafipws\__init__.py                    4      0   100%
test2\Lib\site-packages\PyAfipWs-2.7.2520-py2.7.egg\pyafipws\wsremcarne.py                430     66    85%
-----------------------------------------------------------------------------------------------------------

=================== 40 passed, 13 warnings in 5.64 seconds ====================

@chazuttu chazuttu requested a review from reingart July 27, 2021 07:07
@reingart reingart merged commit 34c7d32 into PyAr:main Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants