Skip to content

Conversation

@chazuttu
Copy link
Collaborator

@chazuttu chazuttu commented Jun 20, 2021

Summary

fixes the issues that arose from merging the tests from PR #59.
This is also in according to issue #6 and issue from chazuttu/Pyafipws.

There is an update in requirements.txt file and
cassettes are generated from recording with pytest-vcr.

Checklist

  • Classes, Variables, function and methods logic ok
  • Comments written explaining what the code does
  • All python code is PEP8 compliant (run black .)
  • No lint issues (run flake8)
  • Test coverage with pytest implemented
  • Reviewers assigned (at least 1 mentor)

Manual test evidence

$ pytest

================================================== test session starts ==================================================
platform win32 -- Python 3.9.2, pytest-6.2.3, py-1.10.0, pluggy-0.13.1
rootdir: C:\Users\shiva\OneDrive\Desktop\Pyafipaws_Utkarsh\pyafipws
plugins: html-3.1.1, metadata-1.11.0, vcr-1.0.2
collected 236 items

tests\test_ws_sr_padron.py s.sx                                                                                    [  1%]
tests\test_wsaa.py .....                                                                                           [  3%]
tests\test_wsaa_crypto.py ....                                                                                     [  5%]
tests\test_wsbfev1.py ..........                                                                                   [  9%]
tests\test_wscdc.py s.......                                                                                       [ 13%]
tests\test_wsct.py ..........xx..xxxxxxxxxxssxxxxxx                                                                [ 26%]
tests\test_wsfev1.py ......                                                                                        [ 29%]
tests\test_wsfev1_dummy.py .                                                                                       [ 29%]
tests\test_wsfexv1.py ..........                                                                                   [ 33%]
tests\test_wslsp.py ......................................x.                                                       [ 50%]
tests\test_wsltv.py ............................x.                                                                 [ 63%]
tests\test_wslum.py ........................x.                                                                     [ 74%]
tests\test_wsmtx.py ..............x......x..........x                                                              [ 88%]
tests\test_wsremcarne.py ...........................                                                               [100%]

=================================================== warnings summary ==================================================== 
finaa\lib\site-packages\pysimplesoap\transport.py:141
  c:\users\shiva\onedrive\desktop\pyafipaws_utkarsh\pyafipws\finaa\lib\site-packages\pysimplesoap\transport.py:141: DeprecationWarning: inspect.getargspec() is deprecated since Python 3.0, use inspect.signature() or inspect.getfullargspec()    
    if 'timeout' in inspect.getargspec(httplib2.Http.__init__)[0]:

finaa\lib\site-packages\future\standard_library\__init__.py:65
  c:\users\shiva\onedrive\desktop\pyafipaws_utkarsh\pyafipws\finaa\lib\site-packages\future\standard_library\__init__.py:65: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses

tests/test_ws_sr_padron.py::test_consultar_a5
  c:\users\shiva\onedrive\desktop\pyafipaws_utkarsh\pyafipws\finaa\lib\site-packages\pysimplesoap\simplexml.py:49: Runtimel.py:49: RuntimeWarning: removing unsupported UTC offset
    warnings.warn('removing unsupported UTC offset', RuntimeWarning)

-- Docs: https://docs.pytest.org/en/stable/warnings.html
================================ 206 passed, 5 skipped, 25 xfailed, 3 warnings in 15.72s ================================ ===============

chazuttu and others added 8 commits June 19, 2021 21:25
Signed-off-by: UTKARSH KUMAR <[email protected]>
Signed-off-by: UTKARSH KUMAR <[email protected]>
Signed-off-by: UTKARSH KUMAR <[email protected]>
Signed-off-by: UTKARSH KUMAR <[email protected]>
Signed-off-by: UTKARSH KUMAR <[email protected]>
Signed-off-by: UTKARSH KUMAR <[email protected]>
@chazuttu chazuttu force-pushed the fixed_test_gsoc19 branch from a17d42c to 6f4cd80 Compare June 20, 2021 19:50
Signed-off-by: UTKARSH KUMAR <[email protected]>
@chazuttu chazuttu requested a review from reingart June 20, 2021 19:59
Copy link
Member

@reingart reingart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge if no objections from other mentors and referents (@NicolasSandoval / @lukio)
I left some comments to create tickets, specially:

  • Reuse VCR cassete dir fixture
  • Review/Reuse WSAA authentication fixture
  • Converts TestFEX from UnitTest to pytest

chazuttu added 3 commits June 22, 2021 06:32
Signed-off-by: UTKARSH KUMAR <[email protected]>
@chazuttu chazuttu requested a review from reingart June 22, 2021 01:06
@reingart reingart merged commit 33b5895 into PyAr:main Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants