forked from reingart/pyafipws
-
Couldn't load subscription status.
- Fork 16
Fixed tests from gsoc19 #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: UTKARSH KUMAR <[email protected]>
Signed-off-by: UTKARSH KUMAR <[email protected]>
Signed-off-by: UTKARSH KUMAR <[email protected]>
Signed-off-by: UTKARSH KUMAR <[email protected]>
Signed-off-by: UTKARSH KUMAR <[email protected]>
Signed-off-by: UTKARSH KUMAR <[email protected]>
Signed-off-by: UTKARSH KUMAR <[email protected]>
a17d42c to
6f4cd80
Compare
Signed-off-by: UTKARSH KUMAR <[email protected]>
Signed-off-by: UTKARSH KUMAR <[email protected]>
reingart
approved these changes
Jun 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will merge if no objections from other mentors and referents (@NicolasSandoval / @lukio)
I left some comments to create tickets, specially:
- Reuse VCR cassete dir fixture
- Review/Reuse WSAA authentication fixture
- Converts TestFEX from UnitTest to pytest
Signed-off-by: UTKARSH KUMAR <[email protected]>
Signed-off-by: UTKARSH KUMAR <[email protected]>
Signed-off-by: UTKARSH KUMAR <[email protected]>
reingart
approved these changes
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes the issues that arose from merging the tests from PR #59.
This is also in according to issue #6 and issue from chazuttu/Pyafipws.
There is an update in requirements.txt file and
cassettes are generated from recording with pytest-vcr.
Checklist
Manual test evidence
$ pytest