feat: lovely lesson layout #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP on #15 License: MIT Signed-off-by: Oli Evans <[email protected]>
License: MIT Signed-off-by: Oli Evans <[email protected]>
|
Added styles for inline code and code blocks in lesson text
|
|
Love it! |
|
One thing we lost was the "next lesson" button on success. Was that an oversight or is there a design reason you think it should be removed? |
|
Submit button should be replaced with the Next button. Perhaps that's too subtle. |
|
If we change the button color, maybe animate it, it'll be pretty obvious :) |
|
just to check, is the next button showing for you? It should already be changing colour and "submit" should be replaced with "next" when you complete an exercise. |
|
It is, I guess I just didn't notice it :( Maybe we should add a bouncing CSS animation? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP on #15
Initial
oh noes
YASSSSSS QUEEEEN
License: MIT
Signed-off-by: Oli Evans [email protected]