Skip to content

Conversation

@julian-amplica
Copy link

Part of ProjectLibertyLabs/custodial-wallet#1526

@julian-amplica julian-amplica requested a review from pfrank13 July 16, 2025 19:50
Copy link
Collaborator

@pfrank13 pfrank13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really a question

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested this in consuming projects, I ask because it may be the constructor is assumed to only take one value which will probably fail either at runtime or when the code is generated to use this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup—tests are all good in CW and saas-frequency-client

@pfrank13 pfrank13 merged commit 486a9fc into unfinished_develop Jul 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants