Skip to content

Conversation

@gangstead
Copy link

@gangstead gangstead commented Apr 12, 2024

I was getting an error when starting the container:

		/src/node_modules/micromatch/index.js:44  
		let isMatch = picomatch(String(patterns[i]), { ...options, onResult }, true);  
		                                               ^^^  
		SyntaxError: Unexpected token ...

In case the markdown formatter messes it up the error is at the object spread operator which was added in node v8.6.0 (source: node.green)

With the current base image, Alpine 3.5 the latest version of node is v6.9.5 (see https://dl-cdn.alpinelinux.org/alpine/v3.5/main/x86_64/). This PR updates it to Alpine 3.19 and node 20.12.2. I've also got this built in the package for my fork and I'm already using it in my cluster https://github.com/gangstead/osrm-frontend/pkgs/container/osrm-frontend

phofman added a commit to codetitans/osrm-frontend that referenced this pull request Apr 14, 2024
@donno
Copy link

donno commented Aug 6, 2024

The error described was reported in #377.

Copy link

@hopfi-at hopfi-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works at my installation

@frodrigo
Copy link
Member

frodrigo commented Mar 1, 2025

Closed in favour of #383

@frodrigo frodrigo closed this Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants