Camera: Allow setting fallback physical ID for logical camera [2/2] #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Redmi Note 8 (ginkgo): * miui camera uses logical id 61 as depth sensor on portrait mode but oss libcam maps it to physical id 2 which is wrong, our physical id of depth sensor is 20 so we must hack it this way Set appropriate system property, for example: persist.sys.camera.fallback_id_2=20 Change-Id: I0c42813d8529b0d769ee8abd0307da97fbfecf5d Signed-off-by: Edwiin Kusuma Jaya <kutemeikito0905@gmail.com>
ShukakuZa
pushed a commit
that referenced
this pull request
Nov 9, 2024
Utilizes a SceneTransitionLayout to animate between the standard layout bouncer when it's split and when it's not split across the foldable hinge. Fix: 309524547 Flag: ACONFIG com.systemui.scene_container DEVELOPMENT Test: manually verified on foldable device - all three auth methods were tested for proper layout on all four possible configs: folded/unfolded x horizontal/vertical. Test: manually verified that PIN and pattern animated to the bottom inner display when entering the tabletop posture and animate back when returning to the flat posture. Test: manually verified that password doesn't animate. Test: see videos attached to the bug in commment #2 Change-Id: I551a1892b32712de68090e4ba730b2b44081616a
ShukakuZa
pushed a commit
that referenced
this pull request
Nov 14, 2024
Cmd line: /system/bin/servicemanager
ABI: 'x86_64'
"servicemanager" sysTid=202
NOTE: Function names and BuildId information is missing for some frames due
NOTE: to unreadable libraries. For unwinds of apps, only shared libraries
NOTE: found under the lib/ directory are readable.
NOTE: On this device, run setenforce 0 to make the libraries readable.
NOTE: Unreadable libraries:
NOTE: /system/lib64/bootstrap/libc.so
#00 pc 00000000000babda /system/lib64/bootstrap/libc.so
#1 pc 0000000000017819 /system/lib64/libutils.so (android::Looper::pollAll(int, int*, int*, void**)+441) (BuildId: 2ed0ced7383d1676a37aed1236486ac3)
#2 pc 0000000000011a25 /system/bin/servicemanager (main+1157) (BuildId: 509b83cb97addfa90aaa4ad911c2a3df)
#3 pc 00000000000547a9 /system/lib64/bootstrap/libc.so
Bug: 314088872
Test: am hang, and check /data/anrs...
Change-Id: Ic754c0fbe13f6986e1493da4167fbbc8d2388304
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Redmi Note 8 (ginkgo):
Set appropriate system property, for example:
persist.sys.camera.fallback_id_2=20
Change-Id: I0c42813d8529b0d769ee8abd0307da97fbfecf5d