Skip to content

Conversation

@mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Apr 4, 2022

Rename projects & files from WorkloadManager to WorkloadManager.

@mocsharp mocsharp added this to the POC milestone Apr 4, 2022
@mocsharp mocsharp self-assigned this Apr 4, 2022
@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #75 (6a77a30) into develop (e8e4f76) will not change coverage.
The diff coverage is 0.00000%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop         #75   +/-   ##
=============================================
  Coverage   53.64583%   53.64583%           
=============================================
  Files              8           8           
  Lines            192         192           
  Branches           8           8           
=============================================
  Hits             103         103           
  Misses            88          88           
  Partials           1           1           
Flag Coverage Δ
unittests 53.64583% <0.00000%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Configuration/ConfigurationValidator.cs 0.00000% <ø> (ø)
src/Configuration/WorkflowManagerOptions.cs 0.00000% <ø> (ø)
...orkflowManager/Logging/FileLoggingTextFormatter.cs 100.00000% <ø> (ø)
src/WorkflowManager/Program.cs 0.00000% <0.00000%> (ø)
...vices/DataRetentionService/DataRetentionService.cs 94.44444% <ø> (ø)
src/WorkflowManager/Services/Http/Startup.cs 0.00000% <0.00000%> (ø)
...nager/Test/Logging/FileLoggingTextFormatterTest.cs 100.00000% <ø> (ø)
...s/DataRetentionService/DataRetentionServiceTest.cs 100.00000% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8e4f76...6a77a30. Read the comment docs.

@mocsharp mocsharp changed the title Rename Workflow to Workload Rename Workload to Workflow Apr 4, 2022
Copy link
Collaborator

@JossSparkesAnswer JossSparkesAnswer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To not create a confusing project I wonder if it is worth changing all mentions of workload manager. e.g. in csproj names, comments etc. Ive attached a screenshot of what the global search returned on VScode

image

Signed-off-by: Victor Chang <[email protected]>
@mocsharp mocsharp force-pushed the vchang/rename-to-workflow branch from 2ab2622 to 2c905cc Compare April 7, 2022 15:18
@mocsharp mocsharp force-pushed the vchang/rename-to-workflow branch from 2c905cc to 7001bd7 Compare April 7, 2022 15:21
Signed-off-by: Victor Chang <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 7, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

47.6% 47.6% Coverage
0.0% 0.0% Duplication

@mocsharp mocsharp merged commit fab8ac8 into develop Apr 7, 2022
@mocsharp mocsharp deleted the vchang/rename-to-workflow branch April 7, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Development

Successfully merging this pull request may close these issues.

4 participants