Skip to content

Conversation

@joshliberty
Copy link

@joshliberty joshliberty commented Mar 18, 2022

Bring documentation in line with recent discussions

@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #71 (aa3c3b6) into main (411c0c0) will decrease coverage by 0.76629%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main         #71         +/-   ##
===================================================
- Coverage   88.50575%   87.73946%   -0.76630%     
===================================================
  Files             22          22                 
  Lines            522         522                 
  Branches          20          20                 
===================================================
- Hits             462         458          -4     
- Misses            55          57          +2     
- Partials           5           7          +2     
Flag Coverage Δ
unittests 87.73946% <ø> (-0.76630%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...vices/DataRetentionService/DataRetentionService.cs 92.59259% <0.00000%> (-7.40741%) ⬇️
...ionDiscoveryService/ApplicationDiscoveryService.cs 92.59259% <0.00000%> (-7.40741%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 411c0c0...aa3c3b6. Read the comment docs.

@joshliberty joshliberty changed the title update software architecture design documentation in line with refine… Update software architecture design documentation Mar 18, 2022
Josh Liberty added 4 commits March 18, 2022 14:11
@joshliberty joshliberty marked this pull request as ready for review March 29, 2022 16:05
@joshliberty joshliberty requested a review from mocsharp March 29, 2022 16:05
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Collaborator

@mocsharp mocsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshliberty joshliberty merged commit 2138209 into main Mar 30, 2022
@mocsharp mocsharp deleted the jliberty/sadd-update branch August 23, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants