Skip to content

Fix logging event IDs #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2022
Merged

Fix logging event IDs #541

merged 1 commit into from
Nov 2, 2022

Conversation

@mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Oct 28, 2022 •
edited
Loading

Description

Fixes event IDs

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@mocsharp mocsharp added the bug Something isn't working label Oct 28, 2022
@mocsharp mocsharp added this to the 0.2.0 milestone Oct 28, 2022
@mocsharp mocsharp requested a review from neildsouth October 28, 2022 20:23
@mocsharp
Fix logging event IDs
3fe2f94 
Signed-off-by: Victor Chang <[email protected]>
@mocsharp mocsharp force-pushed the vchang/fix-error-codes branch from 748dfdd to 3fe2f94 Compare November 2, 2022 15:37
@mocsharp mocsharp merged commit 3375b78 into develop Nov 2, 2022
@mocsharp mocsharp deleted the vchang/fix-error-codes branch November 2, 2022 15:38
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented Mar 9, 2023

🎉 This issue has been resolved in version 0.1.1 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackschofield23 jackschofield23 jackschofield23 approved these changes

@neildsouth neildsouth Awaiting requested review from neildsouth

Assignees

No one assigned

Labels

bug Something isn't working

Projects

Clinical Data Pipelines
Status: Done

Milestone

0.1.1

Development

Successfully merging this pull request may close these issues.

3 participants

@mocsharp @jackschofield23