Skip to content

Conversation

@jackschofield23
Copy link
Contributor

@jackschofield23 jackschofield23 commented Sep 21, 2022

Signed-off-by: Jack Schofield [email protected]

Description

Fixes #434

makes the not found response a problem details object

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

@jackschofield23 jackschofield23 marked this pull request as ready for review September 21, 2022 14:10
@RemakingEden
Copy link
Member

Needs integration tests

@RemakingEden RemakingEden self-requested a review September 21, 2022 14:24
Signed-off-by: Jack Schofield <[email protected]>
Signed-off-by: Jack Schofield <[email protected]>
@jackschofield23 jackschofield23 force-pushed the jschofield/fix-not-found-response branch from 1bbda3e to 1cade95 Compare September 22, 2022 08:38
Copy link
Member

@RemakingEden RemakingEden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@RemakingEden RemakingEden merged commit 787f1c6 into develop Sep 22, 2022
@RemakingEden RemakingEden deleted the jschofield/fix-not-found-response branch September 22, 2022 09:32
jackschofield23 added a commit that referenced this pull request Sep 22, 2022
* fix not found workflow response

Signed-off-by: Jack Schofield <[email protected]>

* fix test

Signed-off-by: Jack Schofield <[email protected]>

* Changed error assertion to look for basic layout of errors as well as content

Signed-off-by: RemakingEden <[email protected]>

Signed-off-by: Jack Schofield <[email protected]>
Signed-off-by: RemakingEden <[email protected]>
Co-authored-by: RemakingEden <[email protected]>
Signed-off-by: Jack Schofield <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Strange response when workflow non-existent ID is updated

3 participants