Skip to content

export task handling #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 21, 2022
Merged

export task handling #241

merged 5 commits into from
Jul 21, 2022

Conversation

@jackschofield23
Copy link
Contributor

@jackschofield23 jackschofield23 commented Jul 19, 2022 •
edited
Loading

Description

Modifies the file export to be a specific export task

Status

In Progress

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@jackschofield23 jackschofield23 force-pushed the jschofield/export-task-handling branch 2 times, most recently from e7717e0 to 307d787 Compare July 20, 2022 08:35
@jackschofield23 jackschofield23 marked this pull request as ready for review July 20, 2022 09:47
@jackschofield23 jackschofield23 force-pushed the jschofield/export-task-handling branch from 391a839 to 752844c Compare July 20, 2022 14:15
@jackschofield23
update task export
d338d9c 
Signed-off-by: Jack Schofield <[email protected]>
@jackschofield23
fix tests
aa84e23 
Signed-off-by: Jack Schofield <[email protected]>
@jackschofield23
add tests
640dab0 
Signed-off-by: Jack Schofield <[email protected]>
@jackschofield23
reduce complexity
4889f62 
Signed-off-by: Jack Schofield <[email protected]>
@jackschofield23
address codesmells
afcf474 
Signed-off-by: Jack Schofield <[email protected]>
@jackschofield23 jackschofield23 force-pushed the jschofield/export-task-handling branch from 752844c to afcf474 Compare July 21, 2022 08:08
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

86.4% 86.4% Coverage
0.0% 0.0% Duplication

@jackschofield23 jackschofield23 merged commit 53760ec into develop Jul 21, 2022
@mocsharp mocsharp deleted the jschofield/export-task-handling branch June 11, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RemakingEden RemakingEden RemakingEden approved these changes

@lillie-dae lillie-dae Awaiting requested review from lillie-dae

@neildsouth neildsouth Awaiting requested review from neildsouth

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jackschofield23 @RemakingEden