Skip to content

handle task artifacts - workflow executer #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 9, 2022
Merged

handle task artifacts - workflow executer #131

merged 9 commits into from
Jun 9, 2022

Conversation

@jackschofield23
Copy link
Contributor

@jackschofield23 jackschofield23 commented May 20, 2022 •
edited
Loading

Changes required for #52 .

Description

Add task artifacts logic to the workflow executer (workflow creation message and task update message)

Status

In Progress

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog
  • Any new files have copyright headers
  • Code coverage above 70%
  • TODO items resolved

@jackschofield23 jackschofield23 marked this pull request as ready for review May 23, 2022 07:52
@jackschofield23 jackschofield23 force-pushed the 52-handle-task-artifacts-workflow-executer branch 7 times, most recently from 1ad93f7 to edb9d1f Compare May 23, 2022 13:30
@elleyouseewhy elleyouseewhy added this to the POC milestone May 24, 2022
@jackschofield23 jackschofield23 force-pushed the 52-handle-task-artifacts-workflow-executer branch 3 times, most recently from 4a25ec4 to bb15db3 Compare May 25, 2022 09:38
mocsharp
mocsharp reviewed Jun 1, 2022
View reviewed changes
lillie-dae
lillie-dae reviewed Jun 6, 2022
View reviewed changes
mocsharp
mocsharp reviewed Jun 7, 2022
View reviewed changes
mocsharp
mocsharp approved these changes Jun 7, 2022
View reviewed changes
Copy link
Collaborator

@mocsharp mocsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May want to fix some of the warnings if possible.

@jackschofield23 jackschofield23 self-assigned this Jun 8, 2022
@jackschofield23 jackschofield23 force-pushed the 52-handle-task-artifacts-workflow-executer branch 2 times, most recently from 137230f to b00d09e Compare June 8, 2022 14:53
@jackschofield23
Add artifact mapper
b1d6215 
Signed-off-by: Jack Schofield <[email protected]>
@jackschofield23
update messaging package
599a45f 
Signed-off-by: Jack Schofield <[email protected]>
@jackschofield23
add storage check for artifacts
7b9bcf3 
Signed-off-by: Jack Schofield <[email protected]>
@jackschofield23
update messaging package
384cfde 
Signed-off-by: Jack Schofield <[email protected]>
@jackschofield23
update sonar linting
9a46245 
Signed-off-by: Jack Schofield <[email protected]>
@jackschofield23
workflow executer changes
302c26c 
Signed-off-by: Jack Schofield <[email protected]>
@jackschofield23
use updated taskUpdate event
20353ca 
Signed-off-by: Jack Schofield <[email protected]>
@jackschofield23
Address comments
590204f 
Signed-off-by: Jack Schofield <[email protected]>
@jackschofield23
address comments and code smells
58993d2 
Signed-off-by: Jack Schofield <[email protected]>
@jackschofield23 jackschofield23 force-pushed the 52-handle-task-artifacts-workflow-executer branch from b00d09e to 58993d2 Compare June 9, 2022 08:35
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 19 Code Smells

72.9% 72.9% Coverage
0.0% 0.0% Duplication

@jackschofield23 jackschofield23 mentioned this pull request Jun 9, 2022
Closed
@jackschofield23 jackschofield23 merged commit b9efadc into develop Jun 9, 2022
@mocsharp mocsharp deleted the 52-handle-task-artifacts-workflow-executer branch June 11, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mocsharp mocsharp mocsharp approved these changes

@lillie-dae lillie-dae Awaiting requested review from lillie-dae

Assignees

@jackschofield23 jackschofield23

Labels

Awaiting Integration Tests

Projects

None yet

Milestone

POC

Development

Successfully merging this pull request may close these issues.

5 participants

@jackschofield23 @mocsharp @lillie-dae @elleyouseewhy