Fix breast density example application to make it work with SDK v0.6+ #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: M Q <[email protected]>
Signed-off-by: M Q <[email protected]>
|
vikashg
approved these changes
Jun 5, 2024
SimoneBendazzoli93
pushed a commit
to SimoneBendazzoli93/monai-deploy-app-sdk
that referenced
this pull request
Jun 26, 2025
…Project-MONAI#491) * Fix this example application to make it work with SDK v0.6+ Signed-off-by: M Q <[email protected]> * Fix the example app errors and corrected folder name Signed-off-by: M Q <[email protected]> --------- Signed-off-by: M Q <[email protected]> Signed-off-by: Simone Bendazzoli <[email protected]>
SimoneBendazzoli93
pushed a commit
to SimoneBendazzoli93/monai-deploy-app-sdk
that referenced
this pull request
Jul 17, 2025
…Project-MONAI#491) * Fix this example application to make it work with SDK v0.6+ Signed-off-by: M Q <[email protected]> * Fix the example app errors and corrected folder name Signed-off-by: M Q <[email protected]> --------- Signed-off-by: M Q <[email protected]> Signed-off-by: Simone Bendazzoli <[email protected]>
SimoneBendazzoli93
pushed a commit
to SimoneBendazzoli93/monai-deploy-app-sdk
that referenced
this pull request
Jul 17, 2025
…Project-MONAI#491) * Fix this example application to make it work with SDK v0.6+ Signed-off-by: M Q <[email protected]> * Fix the example app errors and corrected folder name Signed-off-by: M Q <[email protected]> --------- Signed-off-by: M Q <[email protected]>
SimoneBendazzoli93
pushed a commit
to SimoneBendazzoli93/monai-deploy-app-sdk
that referenced
this pull request
Jul 17, 2025
…Project-MONAI#491) * Fix this example application to make it work with SDK v0.6+ Signed-off-by: M Q <[email protected]> * Fix the example app errors and corrected folder name Signed-off-by: M Q <[email protected]> --------- Signed-off-by: M Q <[email protected]> Signed-off-by: Simone Bendazzoli <[email protected]>
SimoneBendazzoli93
pushed a commit
to SimoneBendazzoli93/monai-deploy-app-sdk
that referenced
this pull request
Jul 17, 2025
…Project-MONAI#491) * Fix this example application to make it work with SDK v0.6+ Signed-off-by: M Q <[email protected]> * Fix the example app errors and corrected folder name Signed-off-by: M Q <[email protected]> --------- Signed-off-by: M Q <[email protected]> Signed-off-by: Simone Bendazzoli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The breast density example application was first created with App SDK v0.5. Post SDK v0.6 release, the code had been updated and works when running with Python interpreter. The README file, however, was not updated to correctly use the new MONAI Deploy CLI. There was also an application bug that caused model network loading error when run as an MONAI App Package.
Code and the doc were updated and tested in dev env.
BTW, the Sonar Cloud is complaining about code duplication erroneously, which I have not found a way to acknowledge and mark as such.