음식점 db 저장 구현 #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

inyoung0215 merged 14 commits into dev from feat-ny-save-restaurant-data

Nov 15, 2023

Member

inyoung0215 commented Nov 12, 2023

이전에 hashKey 중복 검사 오류 해결 (CatcherItem 엔티티에서 Where 어노테이션 조건을 잘못 걸어줌)
카카오 검색 api 사용 (헤더에 key값을 넣어주어야 해서 프록시 패턴으로 헤더 설정 구현)
테스트용으로 저장된 db 날린 후 적재할 예정

inyoung0215 added 5 commits

November 13, 2023 02:32


          refactor: stream으로 리팩토링

1bbecf7


          feat: header 설정 구현


          feat: 음식점 db 저장 구현

aebfe89


          chore: @where 주석 처리

16f6768


          test: 음식점 저장 성공 테스트

70b7e95

inyoung0215 self-assigned this

inyoung0215 requested review from cheolwon1994, ddnjs, dev-khg and pingu9 as code owners

November 12, 2023 18:11

github-actions bot reviewed

View reviewed changes

src/main/java/com/catcher/batch/common/service/CatcherFeignService.java Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

src/main/java/com/catcher/batch/core/converter/CatcherConverter.java Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

src/main/java/com/catcher/batch/core/domain/command/RegisterRestaurantDataCommand.java Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

src/main/java/com/catcher/batch/core/domain/entity/CatcherItem.java Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

src/main/java/com/catcher/batch/core/dto/RestaurantApiResponse.java Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

src/main/java/com/catcher/batch/core/properties/HeaderPropertyProxy.java Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

src/main/java/com/catcher/batch/core/properties/HeaderSupport.java Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

src/main/java/com/catcher/batch/core/service/CampingService.java Outdated Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

src/main/java/com/catcher/batch/core/service/RestaurantService.java Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

src/main/java/com/catcher/batch/infrastructure/properties/RestaurantProperties.java Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

src/main/java/com/catcher/batch/resource/RestaurantController.java Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

src/main/java/com/catcher/batch/resource/external/ExternalFeign.java Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

src/main/resources/application.properties Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

src/test/java/com/catcher/batch/core/service/RestaurantServiceTest.java Outdated Show resolved Hide resolved

cheolwon1994 reviewed

View reviewed changes

src/main/java/com/catcher/batch/core/domain/entity/CatcherItem.java Outdated Show resolved Hide resolved

src/main/java/com/catcher/batch/core/service/CampingService.java Outdated Show resolved Hide resolved

src/main/java/com/catcher/batch/core/service/RestaurantService.java Outdated Show resolved Hide resolved

src/test/java/com/catcher/batch/core/service/RestaurantServiceTest.java Outdated Show resolved Hide resolved

src/test/java/com/catcher/batch/core/service/RestaurantServiceTest.java Show resolved Hide resolved

dev-khg reviewed

View reviewed changes

src/main/java/com/catcher/batch/core/service/RestaurantService.java Outdated Show resolved Hide resolved

inyoung0215 added 3 commits

November 13, 2023 18:36


          refactor: hashKey 중복 검사 로직 리팩토링

cb43ed1


          chore: delete 컬럼명 수정, @where 수정

b5900d4


          test: 음식점 단위 테스트 코드 리팩토링

325eddb

github-actions bot reviewed

View reviewed changes

src/test/java/com/catcher/batch/core/service/RestaurantServiceTest.java Outdated Show resolved Hide resolved

cheolwon1994 reviewed

View reviewed changes

Contributor

cheolwon1994 left a comment

고생하셨습니다!

src/test/java/com/catcher/batch/core/service/RestaurantServiceTest.java Show resolved Hide resolved


          refactor: category repository 구조 변경

0ebd09e

github-actions bot reviewed

View reviewed changes

src/main/java/com/catcher/batch/core/database/CategoryRepository.java Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

src/main/java/com/catcher/batch/core/service/CampingService.java Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

src/main/java/com/catcher/batch/core/service/RestaurantService.java Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

src/main/java/com/catcher/batch/datasource/CategoryRepositoryImpl.java Show resolved Hide resolved

inyoung0215 added 2 commits

November 14, 2023 21:14


          refactor: saveAll() 대신 save() 사용하도록 변경

9ae0da7


          test: 음식점 단위 테스트 - 중복 객체 검사 코드 리팩토링

d49d1b4

github-actions bot reviewed

View reviewed changes

src/test/java/com/catcher/batch/core/service/RestaurantServiceTest.java Outdated Show resolved Hide resolved

inyoung0215 added 2 commits

November 14, 2023 21:33


          feat: 키값 중복 검사 로직 추가 구현

76d885c


          test: 코드 변경으로 인한 수정

2ed9747

github-actions bot reviewed

View reviewed changes

src/test/java/com/catcher/batch/core/service/RestaurantServiceTest.java Outdated Show resolved Hide resolved

cheolwon1994 reviewed

View reviewed changes

src/test/java/com/catcher/batch/core/service/RestaurantServiceTest.java Outdated Show resolved Hide resolved


          style: 필요없는 괄호 제거

290459a

Co-authored-by: cheolwon1994 <32122076+cheolwon1994@users.noreply.github.com>

github-actions bot reviewed

View reviewed changes

src/test/java/com/catcher/batch/core/service/RestaurantServiceTest.java Outdated Show resolved Hide resolved

cheolwon1994 approved these changes

View reviewed changes

Contributor

cheolwon1994 left a comment •

edited

Loading

리팩토링 필요 부분

데이터 중복 처리
응답에 데이터가 중복되어 들어온 경우 어떻게 해결할 것인가?(테스트 코드도 추가 필요)

완전 똑같은 RestourantItem이 들어온 경우
RestourantItem의 key는 같지만 나머지 정보가 조금 다른 경우

SWIT

리팩토링 티켓

inyoung0215 merged commit 24d160d into dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

github-actions[bot] github-actions[bot] left review comments

dev-khg dev-khg left review comments

cheolwon1994 cheolwon1994 approved these changes

pingu9 Awaiting requested review from pingu9 pingu9 is a code owner

ddnjs Awaiting requested review from ddnjs

Labels

None yet