Skip to content

Use Package Info from Extension Context rather than reading package.json directly #5070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Use Package Info from Extension Context rather than reading package.json directly #5070

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,6 @@ import { getSettings } from "./settings";
import { PowerShellLanguageId } from "./utils";
import { LanguageClientConsumer } from "./languageClientConsumer";

// The most reliable way to get the name and version of the current extension.
// eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/no-var-requires
const PackageJSON: any = require("../package.json");

// The 1DS telemetry key, which is just shared among all Microsoft extensions
// (and isn't sensitive).
const TELEMETRY_KEY = "0c6ae279ed8443289764825290e4f9e2-1a736e7c-1324-4338-be46-fc2a58ae4d14-7255";
Expand Down Expand Up @@ -115,15 +111,23 @@ export async function activate(context: vscode.ExtensionContext): Promise<IPower
],
});

interface IPackageInfo {
name: string;
displayName: string;
version: string;
publisher: string;
}
const packageInfo:IPackageInfo = context.extension.packageJSON;

sessionManager = new SessionManager(
context,
settings,
logger,
documentSelector,
PackageJSON.name,
PackageJSON.displayName,
PackageJSON.version,
PackageJSON.publisher,
packageInfo.name,
packageInfo.displayName,
packageInfo.version,
packageInfo.publisher,
telemetryReporter);

// Register commands that do not require Language client
Expand Down